Add missing functionality to RocksJava#4833
Add missing functionality to RocksJava#4833adamretter wants to merge 31 commits intofacebook:masterfrom
Conversation
|
@adamretter Can you fix the build errors? |
|
@sagar0 hopefully good to go now. Somehow missed a commit previously |
adamretter
force-pushed
the
java-api-enhancements
branch
from
2ef20ff to
629cba0
Compare
adamretter
force-pushed
the
java-api-enhancements
branch
6 times, most recently
from
64289e7 to
26cb5ea
Compare
adamretter
force-pushed
the
java-api-enhancements
branch
from
26cb5ea to
d307df0
Compare
|
@sagar0 I think this is now ready to merge please? |
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@sagar0 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@adamretter has updated the pull request. Re-import the pull request |
|
I restarted the flaky failing appveyor build, and it looks good now. But unfortunately conflicts arose in portal.h in the last one hour. Trying to fix them now. |
|
@adamretter has updated the pull request. Re-import the pull request |
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@sagar0 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
@adamretter : Thanks for this big sync of Java API with the C++ API; greatly appreciate it. I am accepting this now.
There are some minor changes that are needed, like adding the license headers to some of the files, and fixing a few issues pointed by internal linter. But github seems to create one commit per file if I modify directly on github (it might end up creating 20 separate commits or so like the one in 27a06bf); so I'll do them later. Those changes shouldn't change the functionality anyway.
Summary: This is my latest round of changes to add missing items to RocksJava. More to come in future PRs. Pull Request resolved: #4833 Differential Revision: D14152266 Pulled By: sagar0 fbshipit-source-id: d6cff67e26da06c131491b5cf6911a8cd0db0775
|
@adamretter / @sagar0 When is this expected to make a release? I am hoping to use one of the new APIs in RocksDB Java. |
|
@avijayanhwx This patch went into 6.0 branch and we tagged and released 6.0.1 a few days back. |
|
@avijayanhwx @sagar0 I pushed 6.0.1 to Maven Central today. |
|
Thank you @adamretter, @sagar0 |
4 participants
This is my latest round of changes to add missing items to RocksJava. More to come in future PRs.